Fix typos#2811
Merged
jku merged 1 commit intotheupdateframework:developfrom Mar 11, 2025
DimitriPapadopoulos:codespell
Merged
Conversation
| the fetcher at Updater initialization and explicitly depending on requests | ||
| * ngclient: TLS certificate source was changed. Certificates now come from operating | ||
| system certificate store instead of `certifi` (#2762) | ||
| * Test infrastucture has improved and should now be more usable externally, e.g. in |
Contributor
Author
There was a problem hiding this comment.
Is it OK to modify the CHANGELOG?
Member
There was a problem hiding this comment.
in this part certainly: these are still unreleased changes. I think spelling fixes are fine in released ones as well
| metadata_bytes = f.read() | ||
| md_obj = Metadata.from_bytes(metadata_bytes) | ||
| # Comparate that from_bytes/to_bytes doesn't change the content | ||
| # Compare that from_bytes/to_bytes doesn't change the content |
Contributor
Author
There was a problem hiding this comment.
Not sure about this one. Perhaps Check that...?
jku
approved these changes
Mar 11, 2025
| the fetcher at Updater initialization and explicitly depending on requests | ||
| * ngclient: TLS certificate source was changed. Certificates now come from operating | ||
| system certificate store instead of `certifi` (#2762) | ||
| * Test infrastucture has improved and should now be more usable externally, e.g. in |
Member
There was a problem hiding this comment.
in this part certainly: these are still unreleased changes. I think spelling fixes are fine in released ones as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Just fix some typos found by codespell.